Skip to content

fix: Boolean toggles in the Trigger Dag / FlexibleForm params grid were#69847

Open
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/67852-airflow-67852
Open

fix: Boolean toggles in the Trigger Dag / FlexibleForm params grid were#69847
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/67852-airflow-67852

Conversation

@singlaamitesh

Copy link
Copy Markdown
Contributor

Fixes #67852


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Boolean toggles in the Trigger Dag / FlexibleForm params grid were left-aligned right after the label instead of sharing the right edge with other controls; added width='full' and justifyContent='flex-end' to FieldBool's Switch so it right-aligns within its control column like AF2's FAB trigger form. The newsfragment was already present but untracked, so it was staged with git add to satisfy the changelog check.

How this was tested: airflow dags test

Copilot AI review requested due to automatic review settings July 14, 2026 05:17
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bbovenzi

Copy link
Copy Markdown
Contributor

Please add a description and screenshots so that we can give you a proper review.

@Vamsi-klu

Copy link
Copy Markdown
Contributor

The component change itself looks like the right small fix: the switch needs both a full-width root and justifyContent="flex-end" to reach the right edge of the existing control column. I think a few follow-ups are needed before this is ready, though.

The new test only checks justifyContent; it would still pass if width="full" were removed, even though that restores the alignment problem. Could you cover both props—for example, by capturing the props passed to the shared Switch? The long-title fixture currently does not exercise that layout because the test mounts FieldBool directly; either render through FieldRow for long-label coverage or remove that unused setup.

Please also replace the new Record<string, any>/ESLint suppression with a narrow type, rename the newsfragment to 69847.bugfix.rst, and complete the PR and commit subjects without the fix: prefix. The requested before/after screenshots are still needed, and airflow dags test does not validate this React UI change; a targeted Vitest run plus UI lint/type-check would be relevant validation.


Drafted-by: Codex (GPT-5); reviewed by @Vamsi-klu before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger DAG modal: two-column layout for params (label left, control right)

4 participants